On Wed, Jan 31, 2024 at 6:48 AM Max Staudt <max@xxxxxxxxx> wrote: > > On 1/31/24 06:07, Roderick Colenbrander wrote: > > Hmpf, euhm euhm I'm not entirely sure what makes sense. From the > > sounds of it are somewhat broken devices (buggy firmwares on them) or > > perhaps one of your controllers (the one with not working touch) is > > perhaps broken. > > > > Some of the patches like handling report id 0x1 (minimal) won't hurt, > > the LED fixes won't either. It makes it easier to add more devices. I > > wonder if we have fully have enough data. > > > > Need to think a bit... > > Yeah, maybe for now, let's focus on the patches that you don't see much trouble with. Better to enable some devices, than none. > > I suggest dropping this here patch (enabling 7545:0104) for now, and if there's ever a change of mind, we can just pick it from the LKML archives :) > > > You can also drop the other patch that you're uneasy about, since I believe these 7545:0104 devices are the only ones I've observed to not implement the what-is-your-MAC-address command. > > > > Max > I agree it sounds like a good idea for now to drop just those 2 paches and just see what other devices are out there (SDL2 has a good ds4 implementation too and they dealt with a lot of devices). May need to get some of the 8bitdo and many others to see some patterns. Thanks, Roderick
