Hi Brenton, On Fri, Jan 19, 2024 at 12:22:45AM -0800, Brenton Simpson wrote: > Thanks Vicki. I didn't realize they were meant to be sorted. Please try avoid top posting. > > Would it be appropriate to add comments explaining the sorting? The > second stanza, in particular, is sorted by the IDs rather than > lexicographically. If someone sorted it naively, they'd end up with a > bigger diff than expected. Yes, we usually sort by VID/PID rather than the name of the device. > > It looks like a few others have escaped sorting; for instance, > "Microsoft X-Box One Elite 2 pad" appears in the wrong place. Yep, sometimes we mess up. > > If Dmitry wants to land this and then follow on with a sort + comment > commit (or do that first and then rebase this on top), that would be > great. I can take a stab too if that's helpful. I applied the patch (moving the entires to the right place). If someone would send a patch fixing the Elite 2 entry and noting the sorting rules I'd be happy to apply it. Thanks. -- Dmitry
