Hi, On 1/26/24 10:53, Phoenix Chen wrote: > Added touch screen info for TECLAST X16 Plus tablet. > > Signed-off-by: Phoenix Chen <asbeltogf@xxxxxxxxx> Thank you for your patch/series, I've applied this patch (series) to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans And thank you for also adding the embedded_fw data so that is will work out of the box for end users. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/touchscreen_dmi.c | 35 ++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > index 0c6733772698..7aee5e9ff2b8 100644 > --- a/drivers/platform/x86/touchscreen_dmi.c > +++ b/drivers/platform/x86/touchscreen_dmi.c > @@ -944,6 +944,32 @@ static const struct ts_dmi_data teclast_tbook11_data = { > .properties = teclast_tbook11_props, > }; > > +static const struct property_entry teclast_x16_plus_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-min-x", 8), > + PROPERTY_ENTRY_U32("touchscreen-min-y", 14), > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1916), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1264), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3692-teclast-x16-plus.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct ts_dmi_data teclast_x16_plus_data = { > + .embedded_fw = { > + .name = "silead/gsl3692-teclast-x16-plus.fw", > + .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 }, > + .length = 43560, > + .sha256 = { 0x9d, 0xb0, 0x3d, 0xf1, 0x00, 0x3c, 0xb5, 0x25, > + 0x62, 0x8a, 0xa0, 0x93, 0x4b, 0xe0, 0x4e, 0x75, > + 0xd1, 0x27, 0xb1, 0x65, 0x3c, 0xba, 0xa5, 0x0f, > + 0xcd, 0xb4, 0xbe, 0x00, 0xbb, 0xf6, 0x43, 0x29 }, > + }, > + .acpi_name = "MSSL1680:00", > + .properties = teclast_x16_plus_props, > +}; > + > static const struct property_entry teclast_x3_plus_props[] = { > PROPERTY_ENTRY_U32("touchscreen-size-x", 1980), > PROPERTY_ENTRY_U32("touchscreen-size-y", 1500), > @@ -1612,6 +1638,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_SKU, "E5A6_A1"), > }, > }, > + { > + /* Teclast X16 Plus */ > + .driver_data = (void *)&teclast_x16_plus_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TECLAST"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Default string"), > + DMI_MATCH(DMI_PRODUCT_SKU, "D3A5_A1"), > + }, > + }, > { > /* Teclast X3 Plus */ > .driver_data = (void *)&teclast_x3_plus_data,
