On Thu, Jan 18, 2024 at 4:54 PM Ting Shen <phoenixshen@xxxxxxxxxxxx> wrote: > > This CL maps ChromeOS EC's BASE_ATTACHED event to SW_DOCK, Hi Ting, The change itself looks good to me, but the userspace can already detect keyboard attachment through USB events. Can you explain why this becomes necessary? And the Linux community doesn't use the term "CL". Please use general terms like "commit" or "patch" as well as imperative sentences [1] in changelog. After that, Reviewed-by: Fei Shao <fshao@xxxxxxxxxxxx> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes Regards, Fei > to allow userspace detect that a keyboard is attached to the > detachable device. > > Signed-off-by: Ting Shen <phoenixshen@xxxxxxxxxx> > --- > > drivers/input/keyboard/cros_ec_keyb.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index 30678a34cf647..d2e0d89d4ffdf 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -128,6 +128,11 @@ static const struct cros_ec_bs_map cros_ec_keyb_bs[] = { > .code = SW_TABLET_MODE, > .bit = EC_MKBP_TABLET_MODE, > }, > + { > + .ev_type = EV_SW, > + .code = SW_DOCK, > + .bit = EC_MKBP_BASE_ATTACHED, > + }, > }; > > /* > -- > 2.43.0.381.gb435a96ce8-goog >
