On Tue, Jan 16, 2024 at 09:43:25PM +0100, Hans de Goede wrote: > Barnabás reported that the change to skip the getid command > when the controller is in translated mode on laptops caused > the Version field of his "AT Translated Set 2 keyboard" > input device to change from ab83 to abba, breaking a custom > hwdb entry for this keyboard. > > Use the standard ab83 id for keyboards when getid is skipped > (rather then that getid fails) to avoid reporting a different > Version to userspace then before skipping the getid. > > Fixes: 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode") > Reported-by: Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> > Closes: https://lore.kernel.org/linux-input/W1ydwoG2fYv85Z3C3yfDOJcVpilEvGge6UGa9kZh8zI2-qkHXp7WLnl2hSkFz63j-c7WupUWI5TLL6n7Lt8DjRuU-yJBwLYWrreb1hbnd6A=@protonmail.com/ > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Applied, thank you. -- Dmitry