Re: Re: [PATCH 1/3] HID: input - Add microphone mute LED support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 04, 2024 at 07:46:32PM +0100, Bernhard Seibold wrote:
> Hi Dmitri,
> 
> On Thu, Jan 04, 2024 at 09:55:42AM -0800, Dmitry Torokhov wrote:
> > No, please do not add new LEDs to input subsystem, and instead use "new"
> > LED APIs that are much more flexible. That is why we built the input
> > leds bridge in direction of input->leds and on the other way around.
> > 
> > The existing input LED definitions are grandfathered because they are
> > exposed to userspace (via evdev), but we will not be adding new ones.
> > 
> > Thanks.
> 
> Sorry, I'm completely new to this subsystem. Did I get it right that
> what you're suggesting is to add something that is similar to
> hidinput_setup_battery() and create the new LED there directly,
> skipping the input subsystem and input-leds completely?

Yes, exactly.

Thanks.

-- 
Dmitry




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux