On Mon, 18 Dec 2023, Guilherme G. Piccoli wrote: > I think I see ... I covered both bases in this patch, but IIUC after > your points above and better looking the code: > > (a) imu_avg_delta_ms is set to JC_IMU_DFLT_AVG_DELTA_MS and it can only > change iff imu_delta_samples_count >= JC_IMU_SAMPLES_PER_DELTA_AVG. > > (b) But the if path related with the imu_delta_samples_count is the one > that also guards the divide-by-zero, so effectively that error condition > cannot happen outside that if path, i.e., my hunk changed nothing. > Ugh...my bad. > > At the same time, the hunk is harmless - it's up to Jiri to decide, we > can drop it (either directly by git rebasing or I can send a V2 if Jiri > prefers), or we can keep it. > > I can try to test internally, github testing may be a bit uncertain in > the timeframe (specially during holidays season). If Jiri thinks the > hunk is harmless and no change is necessary, I'd rather not bother > people for testing now (I don't have the HW). My plan is to send this to Linus in a day or two, to have this fixed for good in 6.7 final to be on the safe side. We can always remove the potentially superfluous check (thanks Rahul for spotting that) later once we get the testing results. Thanks, -- Jiri Kosina SUSE Labs
