On Sun, Dec 17, 2023 at 02:17:01PM +0100, Karel Balej wrote: > From: Karel Balej <balejk@xxxxxxxxx> > > Marvell 88PM88X PMICs provide onkey functionality. Document it. > > Signed-off-by: Karel Balej <balejk@xxxxxxxxx> > --- > .../bindings/input/marvell,88pm88x-onkey.yaml | 30 +++++++++++++++++++ > .../bindings/mfd/marvell,88pm88x.yaml | 4 +++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > > diff --git a/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > new file mode 100644 > index 000000000000..aeb7673189f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/marvell,88pm88x-onkey.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Onkey driver for Marvell 88PM88X PMICs. > + > +maintainers: > + - Karel Balej <balejk@xxxxxxxxx> > + > +description: | > + This module is part of the 88PM88X MFD device. For more details > + see Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml. > + > + The onkey controller is represented as a sub-node of the PMIC node in > + the device tree. > + > +allOf: > + - $ref: input.yaml# > + > +properties: > + compatible: > + const: marvell,88pm88x-onkey > + > +required: > + - compatible > + > +additionalProperties: false > +... > diff --git a/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml b/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml > index e075729c360f..115b41c9f22c 100644 > --- a/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml > +++ b/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml > @@ -50,6 +50,10 @@ examples: > interrupt-parent = <&gic>; > interrupt-controller; > #interrupt-cells = <1>; > + > + onkey { > + compatible = "marvell,88pm88x-onkey"; > + }; Why do you need this? You have no properties for it. The parent driver can instantiate child drivers. You don't need a DT node for that. Rob
