On 12/12/2023 17:57, Conor Dooley wrote: > On Mon, Dec 11, 2023 at 01:14:28PM +0100, Kamel Bouhara wrote: >> Add the TouchNetix axiom I2C touchscreen device tree bindings >> documentation. >> >> Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> >> --- >> .../input/touchscreen/touchnetix,ax54a.yaml | 64 +++++++++++++++++++ >> MAINTAINERS | 6 ++ >> 2 files changed, 70 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchnetix,ax54a.yaml >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchnetix,ax54a.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchnetix,ax54a.yaml >> new file mode 100644 >> index 000000000000..cbdf48fc538b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchnetix,ax54a.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/input/touchscreen/touchnetix,ax54a.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TouchNetix Axiom series touchscreen controller >> + >> +maintainers: >> + - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> >> + >> +allOf: >> + - $ref: /schemas/input/touchscreen/touchscreen.yaml# > > Weird, you add this ref here but do not actually allow any properties > from it since you have "additionalProperties: false" below. > > What's the point of its inclusion? It still brings the type of some fields or the constraints. However need of specifying "poll-interval" already points to missing unevaluatedProperties. Best regards, Krzysztof
