On Tue, Dec 12, 2023 at 07:22:18AM -0800, Guenter Roeck wrote: > On 12/12/23 03:41, Uwe Kleine-König wrote: > > Several affected maintainers already acked, so I guess it's fine to take > > this via the pwm tree. An Ack from the remaining maintainers would be > > very welcome, an alternative would be to split the patch. > > Missing Acks so far: > > - Jean Delvare / Guenter Roeck for drivers/hwmon/pwm-fan.c > > - Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c > > - Liam Girdwood / Mark Brown for drivers/regulator/pwm-regulator.c > > - Helge Deller for drivers/video/fbdev/ssd1307fb.c > Personally I find the change unnecessary and pointless, which is why I > didn't ack it. Even if function names were deemed important enough, keeping > pwm_apply_state() for the time being and just adding pwm_apply_might_sleep() > as duplicate would have done it, all the changes could have gone in long > ago, and per-subsystem cleanup could have been orthogonal. > I refrained from commenting because it might be considered bike shedding, > but I don't want to ack something I deem unnecessary and pointless without > comment. But then don't want to keep arguing either, so I haven't been reading this series because I couldn't tell why I was copied on it, it's only chance that made me open Guenter's mail here... Acked-by: Mark Brown <broonie@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
