On 08/12/2023 13:37, Stefan Eichenberger wrote: > Hi Krzysztof, > > On Thu, Dec 07, 2023 at 05:59:08PM +0100, Krzysztof Kozlowski wrote: >> On 07/12/2023 12:12, Stefan Eichenberger wrote: >>> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml >>> index c40799355ed7..047a5101341c 100644 >>> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml >>> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml >>> @@ -87,6 +87,12 @@ properties: >>> - 2 # ATMEL_MXT_WAKEUP_GPIO >>> default: 0 >>> >>> + atmel,poweroff-in-suspend: >>> + description: | >>> + When this property is set, all supplies are turned off when the system is >>> + going to suspend. >> >> You described the desired Linux feature or behavior, not the actual >> hardware. The bindings are about the latter, so instead you need to >> rephrase the property and its description to match actual hardware >> capabilities/features/configuration etc. > > Thanks a lot for the feedback. Would the following be okay as a > description? > > vdda and vdd are switched off in suspend mode. Are switched by who? Linux driver? Then nothing changed... Best regards, Krzysztof
