Hi everybody, On 2023-09-19 13:40:45+0530, Basavaraj Natikar wrote: > This series adds support for light color temperature and chromaticity. > > v1->v2: > *Rename the series. > *Rename als_illum to als channel as it supports other channels. > *Update patch description to include same reading for the two existing > channels to use channel index to support more hub attributes. > *Keep line length under 80chars in hid-sensor-als. > *Add new channel type IIO_COLORTEMP. > *Update patch description and its subject to add channel type for > chromaticity. > > Basavaraj Natikar (9): > iio: hid-sensor-als: Use channel index to support more hub attributes > iio: Add channel type light color temperature > iio: hid-sensor-als: Add light color temperature support > HID: amd_sfh: Add support for light color temperature > HID: amd_sfh: Add support for SFH1.1 light color temperature > iio: Add channel type for chromaticity > iio: hid-sensor-als: Add light chromaticity support > HID: amd_sfh: Add light chromaticity support > HID: amd_sfh: Add light chromaticity for SFH1.1 This series is breaking probing of hid-sensor-als on Framework 13 AMD laptops [0]. The problem is that the patches require hid-sensors-als sensors to also report chromaticity and color temparature which they don't. When I remove the 'if (ret < 0) return ret;' checks in als_parse_report() probing works and the illuminance/intensity channels that show up behave as expected. Unfortunately this still leaves behind a bunch of unusable channels. A nice fix would be to have something like sysfs/hwmon .is_visible() callback but that's not supported by IIO. One aproach would be to detect the usable channels in als_parse_report() and then adapt the indio_dev->channels based on that information. [0] https://bugzilla.kernel.org/show_bug.cgi?id=218223 #regzbot introduced: 5f05285df691b1e82108eead7165feae238c95ef #regzbot monitor: https://bugzilla.kernel.org/show_bug.cgi?id=218223
