On Mon, 2023-12-04 at 13:31 +0100, Jiri Kosina wrote: > On Wed, 8 Nov 2023, Kai-Heng Feng wrote: > > > Since PCI core and ACPI core already handles PCI PME wake and GPE > > wake > > when the device has wakeup capability, use device_init_wakeup() to > > let > > them do the wakeup setting work. > > > > Also add a shutdown callback which uses pci_prepare_to_sleep() to > > let > > PCI and ACPI set OOB wakeup for S5. > > > > Cc: Jian Hui Lee <jianhui.lee@xxxxxxxxxxxxx> > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> > > Srinivas, do you please have any feedback on this patch? Sorry, slipped out of my review list. I will send today. Thanks, Srinivas > > Thanks, >