Re: [PATCH v3 5/5] input/touchscreen: imagis: add support for IST3032C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Karel,

On 12/2/23 14:48, Karel Balej wrote:
From: Karel Balej <balejk@xxxxxxxxx>

IST3032C is a touchscreen chip used for instance in the
samsung,coreprimevelte smartphone, with which this was tested. Add the
chip specific information to the driver.

Signed-off-by: Karel Balej <balejk@xxxxxxxxx>
---
  drivers/input/touchscreen/imagis.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c
index 84a02672ac47..41f28e6e9cb1 100644
--- a/drivers/input/touchscreen/imagis.c
+++ b/drivers/input/touchscreen/imagis.c
@@ -35,6 +35,8 @@
  #define IST3038B_REG_CHIPID		0x30
  #define IST3038B_WHOAMI			0x30380b
+#define IST3032C_WHOAMI 0x32c
+
Perhaps it should be ordered in alphabetic/alphanumeric order, alternatively, the chip ID values could be grouped.
  struct imagis_properties {
  	unsigned int interrupt_msg_cmd;
  	unsigned int touch_coord_cmd;
@@ -363,6 +365,13 @@ static int imagis_resume(struct device *dev)
static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume); +static const struct imagis_properties imagis_3032c_data = {
+	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
+	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
+	.whoami_cmd = IST3038C_REG_CHIPID,
+	.whoami_val = IST3032C_WHOAMI,
+};
+
  static const struct imagis_properties imagis_3038b_data = {
  	.interrupt_msg_cmd = IST3038B_REG_STATUS,
  	.touch_coord_cmd = IST3038B_REG_STATUS,
@@ -380,6 +389,7 @@ static const struct imagis_properties imagis_3038c_data = {
#ifdef CONFIG_OF
  static const struct of_device_id imagis_of_match[] = {
+	{ .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
  	{ .compatible = "imagis,ist3038b", .data = &imagis_3038b_data },
  	{ .compatible = "imagis,ist3038c", .data = &imagis_3038c_data },
  	{ },

Other than that,

Reviewed-by: Markuss Broks <markuss.broks@xxxxxxxxx>

- Markuss





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux