Re: [PATCH v5 09/17] platform/x86/amd/pmf: Make source_as_str() as non-static

[Mario Limonciello <mario.limonciello@xxxxxxx>]

On 11/17/2023 02:07, Shyam Sundar S K wrote:
> Add amd_pmf prefix to source_as_str() function, so that the function name
> does not look generic. As this is a helper function make it as non-static
> so that it can be reused across multiple PMF features.
>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>

Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>

> ---
>   drivers/platform/x86/amd/pmf/pmf.h | 1 +
>   drivers/platform/x86/amd/pmf/sps.c | 5 +++--
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index fb9ce2593236..216a9f795436 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -600,6 +600,7 @@ int apmf_get_static_slider_granular(struct amd_pmf_dev *pdev,
>   				    struct apmf_static_slider_granular_output *output);
>   bool is_pprof_balanced(struct amd_pmf_dev *pmf);
>   int amd_pmf_power_slider_update_event(struct amd_pmf_dev *dev);
> +const char *amd_pmf_source_as_str(unsigned int state);
>   
>   
>   int apmf_update_fan_idx(struct amd_pmf_dev *pdev, bool manual, u32 idx);
> diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c
> index a70e67749be3..33e23e25c8b1 100644
> --- a/drivers/platform/x86/amd/pmf/sps.c
> +++ b/drivers/platform/x86/amd/pmf/sps.c
> @@ -27,7 +27,7 @@ static const char *slider_as_str(unsigned int state)
>   	}
>   }
>   
> -static const char *source_as_str(unsigned int state)
> +const char *amd_pmf_source_as_str(unsigned int state)
>   {
>   	switch (state) {
>   	case POWER_SOURCE_AC:
> @@ -47,7 +47,8 @@ static void amd_pmf_dump_sps_defaults(struct amd_pmf_static_slider_granular *dat
>   
>   	for (i = 0; i < POWER_SOURCE_MAX; i++) {
>   		for (j = 0; j < POWER_MODE_MAX; j++) {
> -			pr_debug("--- Source:%s Mode:%s ---\n", source_as_str(i), slider_as_str(j));
> +			pr_debug("--- Source:%s Mode:%s ---\n", amd_pmf_source_as_str(i),
> +				 slider_as_str(j));
>   			pr_debug("SPL: %u mW\n", data->prop[i][j].spl);
>   			pr_debug("SPPT: %u mW\n", data->prop[i][j].sppt);
>   			pr_debug("SPPT_ApuOnly: %u mW\n", data->prop[i][j].sppt_apu_only);