IST3032C (and possibly some other models) has touch keys. Add support for them to the imagis driver. Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx> --- This patch depends on the series generalizing the driver and adding IST3032C support: https://lore.kernel.org/all/20231003133440.4696-1-karelb@xxxxxxxxxxxxxxxxxxxx/ --- drivers/input/touchscreen/imagis.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c index 41f28e6e9cb1..5a54ce291655 100644 --- a/drivers/input/touchscreen/imagis.c +++ b/drivers/input/touchscreen/imagis.c @@ -30,6 +30,7 @@ #define IST3038C_FINGER_COUNT_MASK GENMASK(15, 12) #define IST3038C_FINGER_COUNT_SHIFT 12 #define IST3038C_FINGER_STATUS_MASK GENMASK(9, 0) +#define IST3032C_KEY_STATUS_MASK GENMASK(20, 16) #define IST3038B_REG_STATUS 0x20 #define IST3038B_REG_CHIPID 0x30 @@ -43,6 +44,7 @@ struct imagis_properties { unsigned int whoami_cmd; unsigned int whoami_val; bool protocol_b; + bool touch_keys_supported; }; struct imagis_ts { @@ -95,7 +97,7 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id) { struct imagis_ts *ts = dev_id; u32 intr_message, finger_status; - unsigned int finger_count, finger_pressed; + unsigned int finger_count, finger_pressed, key_pressed; int i; int error; @@ -144,6 +146,11 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id) IST3038C_AREA_SHIFT); } + key_pressed = FIELD_GET(IST3032C_KEY_STATUS_MASK, intr_message); + + input_report_key(ts->input_dev, KEY_APPSELECT, (key_pressed & BIT(0))); + input_report_key(ts->input_dev, KEY_BACK, (key_pressed & BIT(1))); + input_mt_sync_frame(ts->input_dev); input_sync(ts->input_dev); @@ -229,6 +236,10 @@ static int imagis_init_input_dev(struct imagis_ts *ts) input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_X); input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_Y); input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 16, 0, 0); + if (ts->tdata->touch_keys_supported) { + input_set_capability(input_dev, EV_KEY, KEY_BACK); + input_set_capability(input_dev, EV_KEY, KEY_APPSELECT); + } touchscreen_parse_properties(input_dev, true, &ts->prop); if (!ts->prop.max_x || !ts->prop.max_y) { @@ -370,6 +381,7 @@ static const struct imagis_properties imagis_3032c_data = { .touch_coord_cmd = IST3038C_REG_TOUCH_COORD, .whoami_cmd = IST3038C_REG_CHIPID, .whoami_val = IST3032C_WHOAMI, + .touch_keys_supported = true, }; static const struct imagis_properties imagis_3038b_data = { -- 2.42.1