Hi Thorsten, On Tue, Oct 10, 2023 at 09:08:23AM +0200, Thorsten Leemhuis wrote: > On 05.10.23 02:13, Jeffery Miller wrote: > > > > On Wed, Oct 4, 2023 at 9:11 AM Dmitry Torokhov > > <dmitry.torokhov@xxxxxxxxx> wrote: > >> > >> In fact, now that I think about it more, we should rework the original > >> patch that added the delay, so that we do not wait these 30 msec in the > >> "fast" reconnect handler. It turns out your original approach was > >> better, but we should not be using retries, but rather the existing > >> reset_delay_ms already defined in rmi platform data. I would appreciate > >> if you try the draft patch at the end of this email (to be applied after > >> reverting your original one adding the delay in psmouse-smbus.c). > > I tested the draft patch and it works. I did revert the previous delay > > patch while testing it. > > > >> I think we need a similar change in synaptics.c as that one also can > >> fall back to PS/2 mode. > >> > > Ah, good point, yes it does appear this needs to be done as well. > > I have tested and will post an new version of the patch to include > > the fix in synaptics.c as well. > > As I'm affected by this problem (and somebody else reported to me in > private to be affected as well) and nothing afaics happened in the past > few days a quick question: > > What's the way forward here now that -rc6 slowly comes into sight? Apply > Jeff's patch to fix my problem? Revert the culprit and fix this properly > up with Dmitry's and Jeff's patches in the next cycle? Something else? I will revert the original patch introducing the delay now that we argee there is a better way. In the mean time I will merge Jeff's patch to reset fast_reconnect handlers, as it is right thing to do anyway, and will get into shape the patch setting reset-delay in RMI code. Thanks. -- Dmitry
