Hi Dmitry, On 19.09.23 00:10, Dmitry Torokhov wrote: > On Mon, Sep 18, 2023 at 06:51:49AM +0200, Javier Carrasco Cruz wrote: >> Hi, >> >> There's an obvious error in the patch I introduced when cleaningup >> (urb->status should be used instead of just status). I will send a v2. > > I think what we need is call to usb_kill_urb(pm->config) in > powermate_disconnect(), right after call to input_unregister_device(). > > Thanks. > That is definitely a more meaningful and elegant solution, so I will check it out and eventually send a v2 with it if everything seems ok. On the other hand usb_kill_urb() is already used on pm->irq before calling input_unregister_device(), so I would move the existing usb_kill_urb to have both calls right after the unregister_device call for code consistency, if that is alright. Thanks and best regards.
