Hi Luca, On Mon, Sep 25, 2023 at 05:22:08AM +0200, Luca Ceresoli wrote: > The irq-gpios description misleading, apparently saying that driving the > IRQ GPIO resets the device, which is even more puzzling as there is a reset > GPIO as well. > > In reality the IRQ pin can be driven during the reset sequence to configure > the client address, as it becomes clear after checking both the datasheet > and the driver code. Improve the text to clarify that. > > Also rephrase to remove reference to the driver, which is not appropriate > in the bindings. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> Reviewed-by: Jeff LaBundy <jeff@xxxxxxxxxxx> > > --- > > Changed in v2: > - reworded to clarify even further > --- > .../devicetree/bindings/input/touchscreen/goodix.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > index 3d016b87c8df..2a2d86cfd104 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > @@ -37,8 +37,9 @@ properties: > maxItems: 1 > > irq-gpios: > - description: GPIO pin used for IRQ. The driver uses the interrupt gpio pin > - as output to reset the device. > + description: GPIO pin used for IRQ input. Additionally, this line is > + sampled by the device on reset deassertion to select the I2C client > + address, thus it can be driven by the host during the reset sequence. > maxItems: 1 > > reset-gpios: > -- > 2.34.1 > Thanks for considering my feedback; the messaging is clear now. Kind regards, Jeff LaBundy
