On Wed, 2023-09-20 at 16:04 +0300, Andy Shevchenko wrote: > On Tue, Sep 19, 2023 at 04:22:45PM -0500, Danny Kaehn wrote: > > Previously the cp2112 driver called INIT_DELAYED_WORK within > > cp2112_gpio_irq_startup, resulting in duplicate initilizations of the > > workqueue on subsequent IRQ startups following an initial request. This > > resulted in a warning in set_work_data in workqueue.c, as well as a rare > > NULL dereference within process_one_work in workqueue.c. > > > > Initialize the workqueue within _probe instead. > > Does it deserve a Fixes tag? I'm not sure -- it does technically fix 13de9cca514ed63604263cad87ca8cb36e9b6489 (HID: cp2112: add IRQ chip handling), but does not apply cleanly to that revision (a.e. with git am) (my understanding is that 'Fixes' is used for stable kernel maintenance?) Thanks, Danny Kaehn