Dne sreda, 20. september 2023 ob 14:58:26 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Best regards,
Jernej
> ---
> drivers/input/touchscreen/sun4i-ts.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/sun4i-ts.c
> b/drivers/input/touchscreen/sun4i-ts.c index bb3c6072fc82..92b2b840b4b7
> 100644
> --- a/drivers/input/touchscreen/sun4i-ts.c
> +++ b/drivers/input/touchscreen/sun4i-ts.c
> @@ -375,7 +375,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int sun4i_ts_remove(struct platform_device *pdev)
> +static void sun4i_ts_remove(struct platform_device *pdev)
> {
> struct sun4i_ts_data *ts = platform_get_drvdata(pdev);
>
> @@ -385,8 +385,6 @@ static int sun4i_ts_remove(struct platform_device *pdev)
>
> /* Deactivate all IRQs */
> writel(0, ts->base + TP_INT_FIFOC);
> -
> - return 0;
> }
>
> static const struct of_device_id sun4i_ts_of_match[] = {
> @@ -403,7 +401,7 @@ static struct platform_driver sun4i_ts_driver = {
> .of_match_table = sun4i_ts_of_match,
> },
> .probe = sun4i_ts_probe,
> - .remove = sun4i_ts_remove,
> + .remove_new = sun4i_ts_remove,
> };
>
> module_platform_driver(sun4i_ts_driver);
