On Sun, 17 Sep 2023, Rahul Rameshbabu wrote:
> Battery information reported by the driver depends on the power supply
> subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD
> Kconfig option is enabled.
>
> Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike")
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx>
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index e11c1c803676..dc227f477601 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD
> tristate "NVIDIA SHIELD devices"
> depends on USB_HID
> depends on BT_HIDP
> + select POWER_SUPPLY
Is there a reason not to do it the standard way using 'depends on', and
not vice versa?
Thanks,
--
Jiri Kosina
SUSE Labs
