On Tue, Aug 22, 2023 at 5:50 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 22, 2023 at 05:38:45PM +0200, Bartosz Golaszewski wrote: > > On Tue, Aug 22, 2023 at 5:28 PM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Tue, Aug 22, 2023 at 05:22:44PM +0200, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > > > > > This make the GPIO irqchip exposed by the CP2112 driver use an immutable > > > > irq_chip struct thus addressing the following warning on probe: > > > > > > > > (cp2112_gpio): not an immutable chip, please consider fixing it! > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3e2977c425ad2789ca18084fff913cceacae75a2 > > > > > > Can you test HID for-next for this hardware? > > > > Ah you beat me to it. I didn't see this one. > > Now looking at it, I don't understand why I added a call to IRQ shutdown > callback... (Looks like it slipped from experimental patch.) If you can > test this, would be nice. > Yeah it works alright. It's already in next but FWIW: Tested-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>