On Aug 21 2023, Andy Shevchenko wrote: > On Mon, Aug 14, 2023 at 11:28:58AM +0200, Jiri Kosina wrote: > > On Mon, 7 Aug 2023, Andy Shevchenko wrote: > > ... > > > > > > > > After I updated GPIO library for the case Benjamin has with CP2112, > > > > > > > I have a brief look into the CP2112 driver itself. > > > > > > > > > > > > > > From GPIO perspective it has two main (maitenance) issues: > > > > > > > - usage of ->to_irq() with IRQ chip present; > > > > > > > - having IRQ chip not immutable. > > > > > > > > > > > > > > Besides that there are plenty small cleanups here and there. > > > > > > > Hence this series. > > > > > > > > > > > > Any comments on this? > > > > > > > > > > Gentle ping^2 for this... > > > > > > > > > > Anything should I do to improve it or is it okay to go as is? > > > > > > > > I have been off pretty much the whole July. I am now back and slowly > > > > making my way through everything that accumulated, I will eventually get > > > > to this. > > > > > > > > Thanks for the patience, > > > > > > Ah, okay, no worries and take your time! > > > > > > I was thinking more on Benjamin's answer as last time he had a hw setup > > > to test... Not sure what the status of that now and if he has a chance > > > to test this or busy enough with something else. > > > > Ah, that would be of course nice. Benjamin? > > Benjamin? It almost full release cycle passed... > I understand if you are busy with something, just tell us. Sorry for not answering, I was off in August until just now. I tried you series just before taking time off, but the problem was that my automation relies on this driver to not be too far from the current upstream, as I need to patch it to be able to inject a node child in it. Which is why I was very interested in the ACPI/DT work so that I do not have to patch the driver. Long story short, I'm not able to test it right now (and I got quite some backlog as you can imagine). IIRC the code was fine, so I think we can just take the series as is, and work on the quirks (if any) later. Cheers, Benjamin
