On Tue, Jul 25, 2023 at 08:37:56AM -0700, Nathan Chancellor wrote: > Clang warns (or errors with CONFIG_WERROR=y): > > drivers/input/keyboard/mcs_touchkey.c:149:49: error: variable 'error' is uninitialized when used here [-Werror,-Wuninitialized] > 149 | dev_err(&client->dev, "i2c read error[%d]\n", error); > | ^~~~~ > include/linux/dev_printk.h:144:65: note: expanded from macro 'dev_err' > 144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) > | ^~~~~~~~~~~ > include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' > 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ > | ^~~~~~~~~~~ > drivers/input/keyboard/mcs_touchkey.c:110:11: note: initialize the variable 'error' to silence this warning > 110 | int error; > | ^ > | = 0 > 1 error generated. > > A refactoring updated the error handling in this block but did not > update the dev_err() call to use fw_ver instead of error. Do so now to > fix the warning and avoid printing uninitialized memory. > > Closes: https://github.com/ClangBuiltLinux/linux/issues/1893 > Fixes: e175eae16c1b ("Input: mcs-touchkey - convert to use devm_* api") > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> Applied, thank you. -- Dmitry
