On Fri, 21 Jul, 2023 18:05:32 -0700 HP Dev <hphyperxdev@xxxxxxxxx> wrote: > Add HyperX controller support to xpad_device and xpad_table. This patch appears to be a resend of a previous patch but does not follow the right practice for patch resends. https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient https://lore.kernel.org/linux-input/ZKxVBULWtM30ZJ7D@xxxxxxxxxx/ > > Reported-by: Chris Toledanes <chris.toledanes@xxxxxx> I think this may not be an accurate use of the Reported-by: git trailer. My guess is you would want to use the Suggested-by: trailer here. This patch does not solve a "regression" in the xpad driver that was reported by someone or some automation but rather adds a new controller to be probed by the driver. https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes > Reviewed-by: Carl Ng <carl.ng@xxxxxx> > Signed-off-by: Max Nguyen <maxwell.nguyen@xxxxxx> > --- > drivers/input/joystick/xpad.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index cdb193317c3b..dfddb0bba8d8 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -130,6 +130,7 @@ static const struct xpad_device { > { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 }, > { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 }, > { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 }, > + { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE }, > { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX }, > { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX }, > { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX }, > @@ -457,6 +458,8 @@ static const struct usb_device_id xpad_table[] = { > { USB_INTERFACE_INFO('X', 'B', 0) }, /* Xbox USB-IF not-approved class */ > XPAD_XBOX360_VENDOR(0x0079), /* GPD Win 2 controller */ > XPAD_XBOX360_VENDOR(0x03eb), /* Wooting Keyboards (Legacy) */ > + XPAD_XBOX360_VENDOR(0x03f0), /* HP HyperX XBox 360 Controllers */ There are no HP HyperX Xbox 360 controllers previously supported or added in this patch. I think the above line should be removed since you only have a XTYPE_XBOXONE type controller. You probably do not need to match against Xbox 360 vendor-specific class since you only implement an Xbox One controller. > + XPAD_XBOXONE_VENDOR(0x03f0), /* HP HyperX Xbox One Controllers */ > XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster Xbox 360 controllers */ > XPAD_XBOX360_VENDOR(0x045e), /* Microsoft Xbox 360 controllers */ > XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft Xbox One controllers */ -- Rahul Rameshbabu
