Hi Dmitry,
I have sent over a new patch. Let me know the whitespace-damage issue is resolved. I will need to adjust the acks since I had missed it.
Regards,
Max
-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Sent: Monday, July 10, 2023 11:59 AM
To: Nguyen, Max <maxwell.nguyen@xxxxxx>
Cc: linux-input@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] Input: xpad - add support for HyperX Game Controllers
CAUTION: External Email
Hi Max,
On Sat, Jul 08, 2023 at 01:30:16AM +0000, Nguyen, Max wrote:
> Add HyperX controller support to xpad_device and xpad_table.
Unfortunately the patch is whitespace-damaged, could you please resubmit?
>
> Reported-by: Chris Toledanes <chris.toledanes@xxxxxx>
> Acked-by: Carl Ng <carl.ng@xxxxxx>
> Acked-by: Jessie Jin <yan.jin1@xxxxxx>
Acks should be given at least in public and they are typically reserved for maintainers or people actively working on the code/driver in question. See Documentation/process/5.Posting.rst
> Signed-off-by: Maxwell Nguyen <maxwell.nguyen@xxxxxx>
> ---
>
> drivers/input/joystick/xpad.c | 3 ++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c
> b/drivers/input/joystick/xpad.c index cdb193317c3b..a5e507b8f619
> 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -130,6 +130,7 @@ static const struct xpad_device {
> { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
> { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
> { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0,
> XTYPE_XBOX360 },
> + { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0,
> + XTYPE_XBOXONE },
> { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0,
> XTYPE_XBOX }, @@ -457,6 +458,8 @@ static const struct usb_device_id xpad_table[] = {
> { USB_INTERFACE_INFO('X', 'B', 0) }, /* Xbox USB-IF not-approved class */
> XPAD_XBOX360_VENDOR(0x0079), /* GPD Win 2 controller */
> XPAD_XBOX360_VENDOR(0x03eb), /* Wooting Keyboards (Legacy) */
> + XPAD_XBOX360_VENDOR(0x03f0), /* HyperX Xbox 360 controllers */
> + XPAD_XBOXONE_VENDOR(0x03f0), /* HyperX Xbox One controllers */
> XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster Xbox 360 controllers */
> XPAD_XBOX360_VENDOR(0x045e), /* Microsoft Xbox 360 controllers */
> XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft Xbox One controllers */
>
Thanks.
--
Dmitry
