On 22/05/2023 17:33, Doug Anderson wrote: > Hi, > > On Fri, May 19, 2023 at 10:07 PM Cong Yang > <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> >> Add an ilitek touch screen chip ili9882t. >> >> Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/input/elan,ekth6915.yaml | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) > > I'm curious about the DT maintainers opinion here. Should this be a > new bindings file, or should it be together in the elan file. If > nothing else, I think the secondary voltage rail name is wrong. I took > a quick peek at a datasheet I found and I don't even see a 3.3V rail > going to the ili9882t. That makes it weird to reuse "vcc33-supply" for > a second supply... It's easier if they are CCed... Best regards, Krzysztof
