On Tue, May 23, 2023 at 9:32 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Tue, May 23, 2023 at 6:11 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > > > On Fri, 19 May 2023, Doug Anderson wrote: > > > > > > These changes are based on the series in [1], which modified the > > > > i2c-hid-of-goodix driver and removed the workaround for a power leakage > > > > issue, so the issue revisits on Mediatek MT8186 boards (Steelix). > > > > > > > > The root cause is that the touchscreen can be powered in different ways > > > > depending on the hardware designs, and it's not as easy to come up with > > > > a solution that is both simple and elegant for all the known designs. > > > > > > > > To address the issue, I ended up adding a new boolean property for the > > > > driver so that we can control the power up/down sequence depending on > > > > that. > > > > > > > > Adding a new property might not be the cleanest approach for this, but > > > > at least the intention would be easy enough to understand, and it > > > > introduces relatively small change to the code and fully preserves the > > > > original control flow. > > > > I hope this is something acceptable, and I'm open to any better > > > > approaches. > > > > > > > > [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@xxxxxxxxxxxx/ > > > > > > > > Changes in v4: > > > > - Minor coding style improvement > > > > > > > > Changes in v3: > > > > - In power-down, only skip the GPIO but not the regulator calls if the > > > > flag is set > > > > > > > > Changes in v2: > > > > - Use a more accurate property name and with "goodix," prefix. > > > > - Do not change the regulator_enable logic during power-up. > > > > > > > > Fei Shao (2): > > > > dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" > > > > property > > > > HID: i2c-hid: goodix: Add support for "goodix,no-reset-during-suspend" > > > > property > > > > > > > > .../bindings/input/goodix,gt7375p.yaml | 9 +++++++++ > > > > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 16 +++++++++++++++- > > > > 2 files changed, 24 insertions(+), 1 deletion(-) > > > > > > Just double-checking if there is any work needed on this series. I > > > think it's ready to land but I wanted to double-check. > > > > I don't think I've been CCed on the dt-binding part (patch 1/2 I guess). > > Has it been Acked? If so, I will happily take it through hid.git, but > > please send it my way. > > Yeah, Rob Acked it: > > https://lore.kernel.org/r/168261692866.3205353.5077242811275926416.robh@xxxxxxxxxx/ > > Fei: can you repost the series with collected tags and make sure to CC Jiri? Sure, I'll do that tomorrow :) Regards, Fei > > Thanks! > > -Doug
