RE: [PATCH] Input: adxl34x - do not hardcode interrupt trigger type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Marek Vasut <marex@xxxxxxx>
> Sent: Dienstag, 9. Mai 2023 22:36
> To: linux-input@xxxxxxxxxxxxxxx
> Cc: Marek Vasut <marex@xxxxxxx>; Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>
> Subject: [PATCH] Input: adxl34x - do not hardcode interrupt trigger type
> 
> Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect
> the settings specified in the firmware description.
> 
> Fixes: e27c729219ad2 ("Input: add driver for ADXL345/346 Digital
> Accelerometers")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/input/misc/adxl34x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index
> eecca671b5884..a3f45e0ee0c75 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -817,8 +817,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
> irq,
>  	AC_WRITE(ac, POWER_CTL, 0);
> 
>  	err = request_threaded_irq(ac->irq, NULL, adxl34x_irq,
> -				   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> -				   dev_name(dev), ac);
> +				   IRQF_ONESHOT, dev_name(dev), ac);
>  	if (err) {
>  		dev_err(dev, "irq %d busy?\n", ac->irq);
>  		goto err_free_mem;
> --
> 2.39.2





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux