On Fri, May 5, 2023 at 8:08 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > - return !gpio_get_value(ts->gpio_pendown); > > + return !gpiod_get_value(ts->gpio_pendown); > > This needs to be > > return !gpiod_get_value_raw(ts->gpio_pendown); There is no such function. The gpio descriptor runpath simply assumes that device trees can be trusted. > I looked at various DTSes we have and they use a mix of active high and > active low annotations, so we have to go with the "raw" variant for now, > and then update to normal one once we update bad DTSes. I just sighed and fixed all the device trees :D Yours, Linus Walleij