On Tue, 2 May 2023 at 18:09, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:
>
> While KUnit tests that cannot be built as a loadable module must depend
> on "KUNIT=y", this is not true for modular tests, where it adds an
> unnecessary limitation.
>
> Fix this by relaxing the dependency to "KUNIT".
>
> Fixes: 08809e482a1c44d9 ("HID: uclogic: KUnit best practices and naming conventions")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
This works here, and I definitely agree we should get rid of these
unnecessary constraints.
Let me know if this should go in via the kselftest/kunit tree, or if
it makes sense to take this via input?
Reviewed-by: David Gow <davidgow@xxxxxxxxxx>
Cheers,
-- David
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 4ce012f83253ec9f..b977450cac75265d 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1285,7 +1285,7 @@ config HID_MCP2221
>
> config HID_KUNIT_TEST
> tristate "KUnit tests for HID" if !KUNIT_ALL_TESTS
> - depends on KUNIT=y
> + depends on KUNIT
> depends on HID_BATTERY_STRENGTH
> depends on HID_UCLOGIC
> default KUNIT_ALL_TESTS
> --
> 2.34.1
>
