On Tue, May 02, 2023 at 04:05:31PM +1000, Peter Hutterer wrote: > On Mon, May 01, 2023 at 06:01:19PM -0700, Dmitry Torokhov wrote: > > input_abs_set_val() can nominally call input_alloc_absinfo() which may > > allocate memory with GFP_KERNEL flag. This does not happen when > > input_abs_set_val() is called by the input core to set current MT slot when > > handling a new input event, but it trips certain static analyzers. > > > > Rearrange the code to access the relevant structures directly. > > > > Reported-by: Teng Qi <starmiku1207184332@xxxxxxxxx> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Reviewed-by: Peter Hutterer <peter.hutterer@xxxxxxxxx> Thanks for the review. > > If git grep is to be believed, this is the only use of > input_abs_set_val. Maybe removing that function is an option? We generate input_abs_[get|set]_<item>() accessors and setters, and there is a couple of users of input_abs_get_val() in the code, so dropping just input_abs_set_val() is kind of hard. It might be useful elsewhere although I have no idea if anyone is actually using it anywhere... Thanks. -- Dmitry
