On Fri, Apr 28, 2023 at 04:15:01PM -0700, Vicki Pfau wrote:
> Hi Dmitry,
>
> On 4/18/23 21:28, Dan Carpenter wrote:
> > On Tue, Apr 18, 2023 at 07:24:14PM -0700, Vicki Pfau wrote:
> >> This moves the sending of the magic packet introduced in db7220c48d8d from
> >> xpad_probe to xpad_start_input to ensure that xpad->dev->dev exists in the
> >> event that an error occurs. This should also fix issues with suspend that may
> >> occur with some controllers.
> >>
> >> Fixes: db7220c48d8d ("Input: xpad - fix support for some third-party controllers")
> >> Signed-off-by: Vicki Pfau <vi@xxxxxxxxxxx>
> >
> > Can you add the syzbot stuff as well and a Reported-by tag for
> > Dongliang Mu as well.
> >
> > Reported-by: syzbot+a3f758b8d8cb7e49afec@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Reported-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
> > Link: https://groups.google.com/g/syzkaller-bugs/c/iMhTgpGuIbM
>
> Do I need to add these to the commit myself and resend, or, barring code revisions, can this be added when you cherry-pick into the tree?
>
This not only have not been tested on hardware, it was not even
compiled:
CC [M] drivers/input/joystick/xpad.o
drivers/input/joystick/xpad.c: In function ‘xpad_start_input’:
drivers/input/joystick/xpad.c:1733:46: error: ‘udev’ undeclared (first use in this function); did you mean ‘cdev’?
1733 | error = usb_control_msg_recv(udev, 0,
| ^~~~
| cdev
At this point I will simply revert the original patch introducing the issue and
we can try landing this again once it is all rested.
Thanks.
--
Dmitry
