Hi Krzysztof and Jiri, On Mon, May 01, 2023 at 08:37:49AM +0200, Krzysztof Kozlowski wrote: > On 28/04/2023 19:09, Jiri Valek - 2N wrote: > > Hi Krzysztof, > > and thanks for the review > > > > On 4/15/23 11:10, Krzysztof Kozlowski wrote: > >> On 15/04/2023 01:38, Jiri Valek - 2N wrote: > >>> Add support for advanced sensitivity settings and signal guard feature. > >>> > >>> Signed-off-by: Jiri Valek - 2N <jiriv@xxxxxxxx> > >>> --- [...] > >>> + microchip,input-treshold: > >>> + minItems: 3 > >>> + maxItems: 8 > >>> + minimum: 0 > >>> + maximum: 127 > >>> + default: 64 > >>> + description: | > >>> + Optional parameter. Specifies the delta threshold that is used to > >>> + determine if a touch has been detected. > >>> + The number of entries must correspond to the number of channels. > >>> + > >>> + microchip,calib-sensitivity: > >>> + minItems: 3 > >>> + maxItems: 8 > >>> + enum: [1, 2, 4] > >>> + default: 1 > >>> + description: | > >>> + Optional parameter supported only for CAP129x. Specifies an array of > >>> + numeric values that controls the gain used by the calibration routine to > >>> + enable sensor inputs to be more sensitive for proximity detection. > >>> + The number of entries must correspond to the number of channels. > >> > >> Most of these properties do not look like hardware properties. Policies > >> and runtime configuration should not be put into DT. Explain please why > >> these are board-specific thus suitable for DT. > > > > All these parameters are intended to set HW properties of touch buttons. > > I know, but some HW properties are software policies. Consider the > simplest example - audio volume of a speaker. It's a hardware property, > but it is not for DT. Software should choose audio volume based on > user's decisions. > > > Each button can have different PCB layout and when you start without > > setting these parameters in DT, then touches won't be detected or you > > will get false positive readings. > > E.g. 'signal-guard' change property of analog input from button to some > > type of shield. > > I made all of them optional for backward compatibility. > > Maybe 'sensitivity-base-shift' is really not necessary to have in DT. > > I will remove it if you agree. > > Keep only ones which are not policies but depend on physical/electrical > characteristic of boards. For capacitive sensing devices such as this, the threshold is specified based on the size of the electrode and properties of the physical overlay. Unlike speaker volume, it is a static property that is often times advised by the module vendor. Based on a quick scan of this patch, all of the properties proposed here seem appropriate for DT and are in line with the properties exposed for comparable devices (e.g. azoteq,thresh). > > Best regards, > Krzysztof > Kind regards, Jeff LaBundy
