On Fri, Apr 28, 2023 at 12:52:43PM -0700, Dmitry Torokhov wrote: > Hi, > > On Fri, Apr 28, 2023 at 11:38:36AM -0700, Siarhei Vishniakou wrote: > > Thanks Biswarup! > > Please avoid top posting. > > > > > Just to add a bit of context: we were concerned with breaking the > > existing uinput usages where the caller might be setting an incorrect > > value (since previously, that had no effect). > > So the 10 second guard was added to fall back to the default behaviour > > for those devices. > > What is the benefit of sending this in uinput? It is not much close > to the exact time the hardware generated the event than the timestamp > generated in the input core, so I do not see why it is needed in uinput. Ah, sorry, my apologies, I mis-parsed the code. -- Dmitry