Re: [PATCH 3/4] Input: pwm-vibra - add support for enable GPIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 27/04/2023 21:34, Luca Weiss wrote:
Some pwm vibrators have a dedicated enable GPIO that needs to be set
high so that the vibrator works. Add support for that optionally.

Signed-off-by: Luca Weiss <luca@xxxxxxxxx>

Reviewed-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
---
  drivers/input/misc/pwm-vibra.c | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)

diff --git a/drivers/input/misc/pwm-vibra.c b/drivers/input/misc/pwm-vibra.c
index c08971c97ad6..2ba035299db8 100644
--- a/drivers/input/misc/pwm-vibra.c
+++ b/drivers/input/misc/pwm-vibra.c
@@ -11,6 +11,7 @@
   *  Copyright (C) 2010, Lars-Peter Clausen <lars@xxxxxxxxxx>
   */
+#include <linux/gpio/consumer.h>
  #include <linux/input.h>
  #include <linux/kernel.h>
  #include <linux/module.h>
@@ -23,6 +24,7 @@
struct pwm_vibrator {
  	struct input_dev *input;
+	struct gpio_desc *enable_gpio;
  	struct pwm_device *pwm;
  	struct pwm_device *pwm_dir;
  	struct regulator *vcc;
@@ -48,6 +50,8 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator)
  		vibrator->vcc_on = true;
  	}
+ gpiod_set_value_cansleep(vibrator->enable_gpio, 1);
+
  	pwm_get_state(vibrator->pwm, &state);
  	pwm_set_relative_duty_cycle(&state, vibrator->level, 0xffff);
  	state.enabled = true;
@@ -80,6 +84,8 @@ static void pwm_vibrator_stop(struct pwm_vibrator *vibrator)
  		pwm_disable(vibrator->pwm_dir);
  	pwm_disable(vibrator->pwm);
+ gpiod_set_value_cansleep(vibrator->enable_gpio, 0);
+
  	if (vibrator->vcc_on) {
  		regulator_disable(vibrator->vcc);
  		vibrator->vcc_on = false;
@@ -142,6 +148,16 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
  		return err;
  	}
+ vibrator->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
+							GPIOD_OUT_LOW);
+	err = PTR_ERR_OR_ZERO(vibrator->enable_gpio);
+	if (err) {
+		if (err != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to request enable gpio: %d\n",
+				err);
+		return err;
+	}
+
  	vibrator->pwm = devm_pwm_get(&pdev->dev, "enable");
  	err = PTR_ERR_OR_ZERO(vibrator->pwm);
  	if (err) {




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux