Right, confirmed on the BLE support. I uploaded a new patch with the C-style comments and added the xbox.com link to the commit message. On Tue, Apr 25, 2023 at 9:07 AM Bastien Nocera <hadess@xxxxxxxxxx> wrote: > > On Tue, 2023-04-25 at 10:46 -0500, Edward Matijevic wrote: > > > > +#define USB_DEVICE_ID_MS_XBOX_CONTROLLER_MODEL_1708 0x02fd > > > > +#define > > > > USB_DEVICE_ID_MS_XBOX_CONTROLLER_MODEL_1708_BLE 0x0b20 > > > The 1708 model uses Bluetooth Classic, not Bluetooth LE. > > > > The new firmware adds Bluetooth LE support to the 1708 > > and prioritizes BLE over Classic which necessitates the change > > The controllers are broken without the "new firmware" IDs which are > > for BLE > > Oh! I completely missed that. So both the 1708 and 1797 used Bluetooth > Classic with the old firmware, and support Bluetooth LE with the new > one. Am I understanding this correctly? > > If that's right, looks like I might need to update Wikipedia ;) > > Seeing as you will be updating the patch for that comment style > problem, you could probably add a reference to this article in the > commit message, it seems authoritative enough: > https://news.xbox.com/en-us/2021/09/08/xbox-controller-firmware-update-rolling-out-to-insiders-starting-today/
