On Mon, Apr 24, 2023 at 03:34:43PM +0300, Nikita Shubin wrote:
> - get keymap from the device tree
> - find register range from the device tree
> - get interrupts from device tree
Note, the below comments may be applied to the whole series where it makes sense.
...
> +#include <linux/of.h>
> +#include <linux/of_platform.h>
Why?
You do not use them. Please, check all your patches to follow the rule: include
only the headers you are really using (or their up level wrappers if required).
(Hint: in this case you have to include mod_devicetable.h)
...
> +static const struct of_device_id ep93xx_keypad_of_ids[] = {
> + { .compatible = "cirrus,ep9301-keypad" },
> + {},
No comma for the terminator entry.
> +};
--
With Best Regards,
Andy Shevchenko
