On Thu, 13 Apr, 2023 17:16:21 +0200 Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > Hi, > > On Apr 10 2023, Rahul Rameshbabu wrote: >> Supports the Thunderstrike (SHIELD 2017) controller. Implements support for >> the Thunderstrike HOSTCMD firmware interface. Adds sysfs attributes about a >> SHIELD device and introduces haptics support for controllers. >> >> Signed-off-by: Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx> >> --- >> MAINTAINERS | 6 + >> drivers/hid/Kconfig | 18 ++ >> drivers/hid/Makefile | 1 + >> drivers/hid/hid-ids.h | 3 + >> drivers/hid/hid-shield.c | 587 +++++++++++++++++++++++++++++++++++++++ > > In addition to what Jiri said, would you mind changing the name to > hid-nvidia-shield.c or just hid-nvidia.c? > The "normal" naming scheme in the hid tree is to group devices by > vendors, and TBH, knowing that the "shield" is from Nvidia is not > necessarily obvious. Ack. I will make the change to hid-nvidia.c in my next submission of this patch. > > Cheers, > Benjamin >
