On Thu, Apr 13, 2023 at 4:03 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 4/13/23 16:01, Benjamin Tissoires wrote: > > On Apr 13 2023, Hans de Goede wrote: > >> Hi Benjamin, > >> > >> Here is a v2 of my series to allow using i2c-hid-of on non OF platforms > >> to allow I2C-HID devices which are not enumerated by ACPI to work on ACPI > >> platforms (by manual i2c_client instantiation using i2c_client_id matching). > >> > >> Changes in v2: > >> - As discussed Drop the patches to consolidate all the i2c-hid-of* > >> drivers into one > >> - Add a comment to the "post-reset-deassert-delay-ms" property reading, > >> that it is a kernel internal (non public) property used between x86 > >> platform code and the i2c-hid driver. > > > > The series is: > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Thank you. > > > I'd rather have at least Doug test this one before we merge it, but I'll > > be out next week, so you'll have to rely on Jiri to merge it (or wait > > for one week). > > Since Doug's devices use the separate specialized drivers and this series > now only touches the generic i2c-hid-of driver I don't think Doug can test > this, or am I missing something ? Ooh, sorry for the confusion. I thought we were having: i2c-hid-of-elan -> i2c-hid-of -> i2c-hid-core When actually, i2c-hid-of-elan is only talking to i2c-hid-core. This is why I wanted i2c-hid-of-elan/goodix to override the property in their probe and then forward the payload to i2c-hid-of... I guess we can take this series right away then Cheers, Benjamin > > Regards, > > Hans > > > > > > >> Hans de Goede (3): > >> HID: i2c-hid-of: Consistenly use dev local variable in probe() > >> HID: i2c-hid-of: Allow using i2c-hid-of on non OF platforms > >> HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of > >> > >> drivers/hid/i2c-hid/Kconfig | 6 +++-- > >> drivers/hid/i2c-hid/i2c-hid-of.c | 38 ++++++++++++++++++++++++-------- > >> 2 files changed, 33 insertions(+), 11 deletions(-) > >> > >> -- > >> 2.39.1 > >> > > >
