On 10/04/2023 18:01, Joel Selvaraj wrote: > Add devicetree bindings for the Focaltech FTS touchscreen drivers. > Subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. > Signed-off-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > --- > .../input/touchscreen/focaltech,fts5452.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/focaltech,fts5452.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts5452.yaml b/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts5452.yaml > new file mode 100644 > index 000000000000..f42868293439 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/focaltech,fts5452.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/focaltech,fts5452.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Focaltech FTS I2C Touchscreen Controller > + > +maintainers: > + - Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > + - Caleb Connolly <caleb@xxxxxxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - focaltech,fts5452 > + - focaltech,fts8719 > + > + reg: > + const: 0x38 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + avdd-supply: > + description: regulator supplying analog power (2.6V to 3.3V). > + > + vddio-supply: > + description: regulator supplying IO power (1.8V). > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - touchscreen-size-x > + - touchscreen-size-y We always put required: before unevaluatedProperties. Base your schema on example-schema.yaml. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
