Hi Rahul, I love your patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on linus/master v6.3-rc4 next-20230331] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Rahul-Rameshbabu/HID-shield-Initial-driver-implementation-with-Thunderstrike-support/20230401-112438 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next patch link: https://lore.kernel.org/r/20230401032150.7424-2-rrameshbabu%40nvidia.com patch subject: [PATCH v1 RESEND 1/1] HID: shield: Initial driver implementation with Thunderstrike support config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20230401/202304011342.6Bh3cWhA-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/febf8c75cc77baaf26a8ae869201cb1df6d67124 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Rahul-Rameshbabu/HID-shield-Initial-driver-implementation-with-Thunderstrike-support/20230401-112438 git checkout febf8c75cc77baaf26a8ae869201cb1df6d67124 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304011342.6Bh3cWhA-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/hid/hid-shield.c:199:6: warning: no previous prototype for 'thunderstrike_hostcmd_req_work_handler' [-Wmissing-prototypes] 199 | void thunderstrike_hostcmd_req_work_handler(struct work_struct *work) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/thunderstrike_hostcmd_req_work_handler +199 drivers/hid/hid-shield.c 198 > 199 void thunderstrike_hostcmd_req_work_handler(struct work_struct *work) 200 { 201 struct thunderstrike *ts = 202 container_of(work, struct thunderstrike, hostcmd_req_work); 203 struct thunderstrike_hostcmd_req_report *report; 204 unsigned long flags; 205 206 report = ts->req_report_dmabuf; 207 208 if (test_and_clear_bit(THUNDERSTRIKE_FW_VERSION_UPDATE, &ts->update_flags)) { 209 thunderstrike_hostcmd_req_report_init( 210 report, THUNDERSTRIKE_HOSTCMD_ID_FW_VERSION); 211 thunderstrike_send_hostcmd_request(ts); 212 } 213 214 if (test_and_clear_bit(THUNDERSTRIKE_BOARD_INFO_UPDATE, &ts->update_flags)) { 215 thunderstrike_hostcmd_req_report_init( 216 report, THUNDERSTRIKE_HOSTCMD_ID_BOARD_INFO); 217 thunderstrike_send_hostcmd_request(ts); 218 } 219 220 if (test_and_clear_bit(THUNDERSTRIKE_HAPTICS_UPDATE, &ts->update_flags)) { 221 thunderstrike_hostcmd_req_report_init( 222 report, THUNDERSTRIKE_HOSTCMD_ID_HAPTICS); 223 224 report->haptics.update = 1; 225 spin_lock_irqsave(&ts->haptics_update_lock, flags); 226 report->haptics.motors = ts->haptics_val; 227 spin_unlock_irqrestore(&ts->haptics_update_lock, flags); 228 229 thunderstrike_send_hostcmd_request(ts); 230 } 231 } 232 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
