On Mon, Mar 20, 2023, 1:44 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 19/03/2023 21:48, Danny Kaehn wrote: > > This is a USB HID device which includes an I2C controller and 8 GPIO pins. > > > > The binding allows describing the chip's gpio and i2c controller in DT > > using the subnodes named "gpio" and "i2c", respectively. This is > > intended to be used in configurations where the CP2112 is permanently > > connected in hardware. > > > > Signed-off-by: Danny Kaehn <kaehndan@xxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > From where did you get it? There was no such tag at v7: > https://lore.kernel.org/all/20230223213147.268-2-kaehndan@xxxxxxxxx/ > nor at v6: > https://lore.kernel.org/all/20230217184904.1290-2-kaehndan@xxxxxxxxx/ > > ??? Hi Krzysztof, My apologies. It looks like you reviewed this in v4 [1]. I had received feedback on v7 that I should be carrying tags from previous reviews forward if minimal / no changes have been made to the patch reviewed, out of respect for reviewers who look at lots of patches (like yourself) [2], and hadn't retroactively applied your tag until v8. Since v4, I'd only made a few changes suggested by Rob, plus added an example of specifying bus recovery GPIOs in the binding, and thought those would fall within the scope of minor changes -- but my apologies if this was a bad assumption! I can remove and re-submit if desired. Thanks, Danny Kaehn [1]: https://lore.kernel.org/all/c999c387-401a-e3a1-f431-2770930c5ecc@xxxxxxxxxx/ [2]: https://lore.kernel.org/all/Y%2FjpME2mb5CqPooj@xxxxxxxxxxxxxxxxxx/
