On 16/03/2023 16:29, Jan Jasper de Kroon wrote: > Add an optional 'goodix-hold-in-reset', to the Goodix touchscreen > device tree binding. When set to true, the touchscreen controller will > be held in reset mode during system suspend, reducing power consumption. > If not present, the property defaults to false. > > Signed-off-by: Jan Jasper de Kroon <jajadekroon@xxxxxxxxx> Don't attach new patchsets to some other threads. It messes with our tools and reading/reviewing process. > --- > Changes from v2 to v3: > - Used imperative mood instead of "This patch adds". > - Dropped "I am submitting this patch to..." as it is redundant. > - Removed the paragraph related to the related patch sent to the > linux-input mailing list as it is not necessary. > - Renamed the hold-in-reset-in-suspend function to > goodix-hold-in-reset to prevent potential naming conflicts with other > functions in the codebase. No functional changes were made. > > Changes from v1 to v2: > - Updated subject prefix to match subsystem. > - Added more detailed description of the change. > - Fixed formatting issues in commit message. > .../devicetree/bindings/input/touchscreen/goodix.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > index 3d016b87c8df..197f8db9acc2 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > @@ -56,6 +56,13 @@ properties: > touchscreen-size-y: true > touchscreen-swapped-x-y: true > > + goodix-hold-in-reset: That's not a vendor prefix... missing coma. > + description: | > + When set to true, the touchscreen controller will be held in reset mode > + during system suspend. This can help reduce power consumption, but may > + cause the touchscreen to take longer to resume when the system is woken > + up from suspend. Anyway, my concerns were not answered, so to be clear: NAK till you answer them. Do not send new versions without answering existing concerns and discussion. Best regards, Krzysztof
