On Wed, 2023-03-15 at 08:04 +0100, Krzysztof Kozlowski wrote: > On 13/03/2023 23:06, Todd Brandt wrote: > > On some platforms there are some platform devices created with > > invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead > > of "HID-SENSOR-INT-020b.39.auto" > > > > This string include some invalid characters, hence it will fail to > > properly load the driver which will handle this custom sensor. Also > > it is a problem for some user space tools, which parse the device > > names from ftrace and dmesg. > > > > This is because the string, real_usage, is not NULL terminated and > > printed with %s to form device name. > > > > To address this, we initialize the real_usage string with 0s. > > > > Philipp Jungkamp created this fix, I'm simply submitting it. I've > > verified it fixes bugzilla issue 217169 > > > > Reported-and-tested-by: Todd Brandt <todd.e.brandt@xxxxxxxxxxxxxxx> > > Signed-off-by: Todd Brandt <todd.e.brandt@xxxxxxxxx> > > SoB denotes that you reported this and tested. Otherwise shall we > start > adding Reported and Tested tags to all of our commits? > I just copied it from someone else's post on the mailing list, I thought it was part of the standard lkml vernacular but I just looked it up and it's explicitly forbidden in Documentation/process/maintainer-top.rst line 385. So the answer is no. I'll not use it again. > > Best regards, > Krzysztof >
