The synaptics_resolution() function always returnd 0. And there is no need to check its result. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e839ffab0289 ("Input: synaptics - add support for Intertouch devices") Signed-off-by: Igor Artemiev <Igor.A.Artemiev@xxxxxxx> --- drivers/input/mouse/synaptics.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index fa021af8506e..4f1182bf9667 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -444,9 +444,7 @@ static int synaptics_query_hardware(struct psmouse *psmouse, if (error) return error; - error = synaptics_resolution(psmouse, info); - if (error) - return error; + synaptics_resolution(psmouse, info); return 0; } -- 2.30.2