On Sat, 11 Feb 2023 17:56:15 +0100 Pavel Machek <pavel@xxxxxx> wrote: > Hi! > > > From: Orlando Chamberlain <orlandoch.dev@xxxxxxxxx> > > > > This driver adds support for the keyboard backlight on Intel T2 Macs > > with internal Magic Keyboards (MacBookPro16,x and MacBookAir9,1) > > > + backlight->hdev = hdev; > > + backlight->cdev.name = "apple::kbd_backlight"; > > ":white:kbd_backlight", plus document this in > Documentation/leds/well-known-leds.txt so that we keep it consistent > accross machines? As in "apple:white:kbd_backlight" or just ":white:kbd_backlight"? It seems like most examples I can see by grepping around use "apple::kbd_backlight", "asus::kbd_backlight" etc, without any colour information or anything between the two colons. Would we want to start having the led names in new drivers (including this one) as "$vendor:$colour:$location_or_description"? I do notice you've also suggested doing that here https://lore.kernel.org/all/Y+I7xNqkq%2FX6Lag+@xxxxxxxxxx/, and that conversation suggests adding the colour won't stop userspace tools from finding the backlight, which is good. One alternative would be to have the colour of the led stored in a sysfs file in the led's sysfs folder, not sure if that'd be better (it does mean the names stay the same), but also I'm not sure what the empty space between the two colons in the current led names is there for, if not colour. > > Thanks, > Pavel
