On Fri, Feb 10, 2023 at 04:36:38PM -0600, Danny Kaehn wrote: > Bind i2c and gpio interfaces to subnodes with names > "i2c" and "gpio" if they exist, respectively. This > allows the gpio and i2c controllers to be described > in firmware as usual. Additionally, support configuring the > i2c bus speed from the clock-frequency device property. Entire series (code-wise, w/o DT bindings, not an expert there) looks good to me, but one thing to address. ... > + dev->gc.fwnode = device_get_named_child_node(&hdev->dev, "gpio"); Using like this bumps a reference count IIRC, so one need to drop it after use. But please double check this. -- With Best Regards, Andy Shevchenko
