On 10.02.2023 14:45, Gergo Koteles wrote:
> On 2023. 02. 10. 12:33, Krzysztof Kozlowski wrote:
>> On 10/02/2023 00:25, Gergo Koteles wrote:
>>> The tri-state-key is a sound profile switch found on the OnePlus 6,
>>> Android maps the states to "mute", "vibrate" and "ring". Expose them as
>>> ABS_SND_PROFILE events.
>>> The previous GPIO numbers were wrong. Update them to the correct
>>> ones.
>>>
>>> Co-developed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
>>> Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
>>> Signed-off-by: Gergo Koteles <soyer@xxxxxx>
>>
>> Where are other patches? I got only 3/3.
>>
> Hi Krzysztof,
>
> Sorry, I missed the --thread option for git format-patch.
>
>>> ---
>>> .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 39 ++++++++++++++++++-
>>> 1 file changed, 38 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>>> index 64638ea94db7..e45d4fdead82 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>>> @@ -52,6 +52,43 @@ key-vol-up {
>>> };
>>> };
>>> + tri-state-key {
>>> + compatible = "gpio-keys";
>>> + label = "Tri-state key";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&tri_state_key_default>;
>>
>> Missing blank line.
>>
>
> I'll add it to v3.
While at it, please put pinctrl-names after pinctrl-0.
>
>>> + state-top {
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
>>
>
> I ran dtbs_check with DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/qcom.yaml. It only shows warnings for msm8996-oneplus3, but not for sdm845-oneplus phones. Is there anything else I need to check?
You're only checking against a schema file which validates msm-id and
machine compatibles. The goal is to not introduce *any* new warnings.
You want to run:
make (your make args) CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb
pre and post your patch.
Konrad
>
>
> ...
> arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb: /: qcom,board-id: 'oneOf' conditional failed, one must be fixed:
> [8, 0, 15801, 15, 8, 0, 15801, 16] is too long
> From schema: /Documentation/devicetree/bindings/arm/qcom.yaml
> ...
> DTC_CHK arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb
> DTC_CHK arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dtb
>
>
> Thanks,
> Gergo
>
>>
>> Best regards,
>> Krzysztof
>>
>
